[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [Rev 01] RFR: 8087555: [ChoiceBox] uncontained value not shown
From:       Ambarish Rapte <arapte () openjdk ! java ! net>
Date:       2020-04-28 12:17:35
Message-ID: uTVfxoRiTwIURiGETD7xB9cQthWDN3Zb92fmVbEmfyU=.6f4d97ca-d0be-4fd8-87b4-1462943a6fc8 () github ! com
[Download RAW message or body]

On Tue, 28 Apr 2020 09:38:56 GMT, Jeanette Winzenburg <fastegal@openjdk.org> wrote:

> > The issue is that ChoiceBoxSkin
> > a) doesn't update the text of the label if the value is not contained in the \
> > items b) doesn't respect converter for label text
> > 
> > Fixed by
> > - listening to value changes to update the label
> > - removing ad-hoc updates (not needed), added update on converter change
> > - passing all label updates through converter
> > 
> > Added test for text updates that failed before the fix and pass after (note: \
> > there were no tests for the display text, so for coveragy, contains also tests \
> > that passed before as well as after)
> 
> Jeanette Winzenburg has updated the pull request incrementally with one additional \
> commit since the last revision: 
> fixed copyright year

Marked as reviewed by arapte (Reviewer).

-------------

PR: https://git.openjdk.java.net/jfx/pull/191


[prev in list] [next in list] [prev in thread] [next in thread]