[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [Rev 01] RFR: 8089828: RTL Orientation, the flag of a mnemonic is not placed under the mnemonic 
From:       Ambarish Rapte <arapte () openjdk ! java ! net>
Date:       2020-03-26 18:11:48
Message-ID: qN1yJ_UN7q8MusqYv5upVlq6Ql_sikKC1Exoy8rwTXo=.ba980f8a-1cbe-40fa-8143-3beb82d86d83 () github ! com
[Download RAW message or body]

On Thu, 26 Mar 2020 06:25:55 GMT, Ajit Ghaisas <aghaisas@openjdk.org> wrote:

> > **Bug :**
> > https://bugs.openjdk.java.net/browse/JDK-8089828
> > 
> > **Root Cause :**
> > RIGHT_TO_LEFT NodeOrientation was not considered during mnemonic position \
> > calculation. 
> > **Fix :**
> > Corrected code to consider RIGHT_TO_LEFT NodeOrientation while calculating \
> > mnemonic position. 
> > **Testing :**
> > Existing manual test is modified to test RTL buttons as well.
> 
> Ajit Ghaisas has updated the pull request incrementally with one additional commit \
> since the last revision: 
> fix file header comment

Marked as reviewed by arapte (Reviewer).

-------------

PR: https://git.openjdk.java.net/jfx/pull/146


[prev in list] [next in list] [prev in thread] [next in thread]