[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: Issue granularity?
From:       Kevin Rushforth <kevin.rushforth () oracle ! com>
Date:       2020-03-25 22:45:01
Message-ID: 5b69d029-d67d-b5df-0ed5-d411bee9511f () oracle ! com
[Download RAW message or body]

It depends on how many there are and how similar they are. If there 
isn't much similarity, then one issue per control is probably fine (and 
may be best). If there is a lot of similar patterns then some grouping 
will help cut down on the number of reviews (and the associated testing).

Ambarish was looking into a few of these, too, so maybe he has some 
thoughts on this.

-- Kevin


On 3/25/2020 6:53 AM, Jeanette Winzenburg wrote:
>
> While working on a memory leak for ChoiceBoxSelection 
> (https://bugs.openjdk.java.net/browse/JDK-8241455) I wrote a test 
> covering the same issue in other controls with selection- and 
> focusModels (the latter if available). Turned out it fails for
>
> - TreeView selection- and focusModel
> - TreeTableView focusModel
> - TabPane selectionModel
>
> all register listeners (eventHandler in the case of TreeView) to 
> properties of the control with strong references, the fix is similar: 
> use weakListeners (if that's the outcome of fixing choiceBoxSelection)
>
> How to procede? Options seem to be
>
> - one issue/pull request per control
> - bulk issue/pull request for the all similar (keeping the current for 
> ChoiceBox as is)
> - include all into the current issue/pull request for ChoiceBox
> - other?
>
>
>
>

[prev in list] [next in list] [prev in thread] [next in thread]