[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [Rev 02] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orienta
From:       Jeanette Winzenburg <fastegal () openjdk ! java ! net>
Date:       2020-02-28 17:27:01
Message-ID: bPrg7ut66etda8fFHy1xtcT5TJEFauTywlt9CDbGKks=.d473c7b4-a0ad-4712-8807-6ef23fdd5b3b () github ! com
[Download RAW message or body]

On Fri, 28 Feb 2020 17:22:39 GMT, Jeanette Winzenburg <fastegal@openjdk.org> wrote:

> > Regarding your suggestion of having forward/backward semantic methods and calling \
> > them in tests -  There are two types of tests -
> > 1. Key action remains same - asserts differ based on NodeOrientation
> > 2. Key action differs based on NodeOrientation - but, asserts remain same
> > 
> > Example of 1 is - test_rt18488_selectToLeft
> > Example of 2 is - test_rt18591_cell_1
> > 
> > Your suggestion can be applied only to the tests of type-2. I will try to update \
> > tests of this type.
> 
> ahh .. okay, missed that difference, thanks :) 
> 
> Hmm, still feels smelly to have to use the parameter for conditional branches \
> (either on the assumption or on the navigation). Will check later

and yes, agree with using parameterized tests at all ... just have this nagging \
feeling that it's not quite done to the end :)

-------------

PR: https://git.openjdk.java.net/jfx/pull/114


[prev in list] [next in list] [prev in thread] [next in thread]