[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [Rev 01] RFR: 8208761: Update constant collections to use the new immutable collections
From:       Nir Lisker <nlisker () openjdk ! java ! net>
Date:       2020-02-28 8:06:01
Message-ID: vUpH1JgXoOiOhuMdV-2OadXRNujXU46mgl2NgAIWYEg=.4e8b1a6a-b092-4d0a-bf3b-e29d1d5469d4 () github ! com
[Download RAW message or body]

On Fri, 28 Feb 2020 01:19:23 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:

> > The pull request has been updated with 1 additional commit.
> 
> I finished my review and tested this on all platforms. It looks good to me.
> 
> The only comment I have is the one inline comment I left in `KeyCodeMap.java` about \
> renaming the "put" method to something with "entry" in the name to reflect what it \
> now does.

> The only comment I have is the one inline comment I left in KeyCodeMap.java about \
> renaming the "put" method to something with "entry" in the name to reflect what it \
> now does.

Will fix it after Ambarish reviews.

-------------

PR: https://git.openjdk.java.net/jfx/pull/104


[prev in list] [next in list] [prev in thread] [next in thread]