[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [Rev 02] RFR: 8212034: Potential memory leaks in jpegLoader.c in error case
From:       Kevin Rushforth <kcr () openjdk ! java ! net>
Date:       2020-02-26 22:19:50
Message-ID: xkmnA1i39HZvYVLg0EXRabdeeoZJiWPtKniiIAZjUKI=.e4672085-9aa5-420f-b8f7-97afcfe08eb9 () github ! com
[Download RAW message or body]

On Mon, 10 Feb 2020 13:27:27 GMT, Ambarish Rapte <arapte@openjdk.org> wrote:

> > Memory allocated in initDecompressor() and decompressIndirect() is not freed in \
> > error case. In error case,
> > 1. Allocated memory should be freed.
> > 2. Appropriate de-initialization jpeg library calls should be added.
> > 
> > Verified that,
> > 1. All unit and systems tests pass on three platforms, and
> > 2. Memory consumption with and without fix is similar by comparing memory before \
> > and after showing 10 jpeg images for 100 times.
> 
> The pull request has been updated with a new target base due to a merge or a \
> rebase.

Marked as reviewed by kcr (Lead).

-------------

PR: https://git.openjdk.java.net/jfx/pull/54


[prev in list] [next in list] [prev in thread] [next in thread]