[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [Rev 01] RFR: 8237770: Error creating fragment phong shader on iOS
From:       Kevin Rushforth <kcr () openjdk ! java ! net>
Date:       2020-01-31 23:49:21
Message-ID: xlER81ZptjKL20CwlKpaABoPJNQe_8hoixfWuIe_XY8=.a55727d5-fcfa-4cfb-b46d-6b6f3071e29b () github ! com
[Download RAW message or body]

On Fri, 31 Jan 2020 23:49:21 GMT, Jose Pereda <jpereda@openjdk.org> wrote:

> > This PR defines a pre-processor in the phong frag files to avoid inline \
> > declaration of #extension when several frags are combined that leads to the \
> > error: 
> > syntax error: #extension must always be before any non-preprocessor tokens
> 
> The pull request has been updated with 1 additional commit.

Looks good.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/93


[prev in list] [next in list] [prev in thread] [next in thread]