[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8237770: Error creating fragment phong shader on iOS
From:       Kevin Rushforth <kcr () openjdk ! java ! net>
Date:       2020-01-31 6:51:37
Message-ID: fUAP9OHvEXqFcPxZixiitGg7qj9rtsW1LJJ6U-RL_x8=.3241dc5e-e85b-4a63-b9dc-4176122d5488 () github ! com
[Download RAW message or body]

On Fri, 24 Jan 2020 11:31:02 GMT, Jose Pereda <jpereda@openjdk.org> wrote:

> This PR defines a pre-processor in the phong frag files to avoid inline declaration \
> of #extension when several frags are combined that leads to the error: 
> syntax error: #extension must always be before any non-preprocessor tokens

I verified that this works correctly. I have a minor style comment for you to \
consider.

modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/diffuse_color.frag \
line 32:

> 31: #extension GL_OES_standard_derivatives : enable
> 32: #define EXTENSION_APPLIED
> 33: #endif

Usual practice is to put the `#define` right after the `#ifndef`, but I don't have a \
strong opinion about that.

-------------



PR: https://git.openjdk.java.net/jfx/pull/93


[prev in list] [next in list] [prev in thread] [next in thread]