[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [Rev 01] RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build
From:       Kevin Rushforth <kcr () openjdk ! java ! net>
Date:       2020-01-31 6:47:30
Message-ID: J2H_T6ekifN7gMFeqZd6VXi8BXzRJlFBgnnIE7CJqRc=.e291006e-d8d3-44ff-9856-fb32c08eaa30 () github ! com
[Download RAW message or body]

On Wed, 29 Jan 2020 15:36:52 GMT, Guru Hb <ghb@openjdk.org> wrote:

> > Marked as reviewed by kcr (Lead).
> 
> > the -m32 option seems to be ignored by the compiler:
> > cl : Command line warning D9002 : ignoring unknown option '-m32'
> > 
> > However, I agree it is better to conditionally remove it.
> "-m32" required for compiling other ports of webkit (WebkitGTK, WPE) and for our \
> platform I haven't tested this feature (i.e cross compiling on a 64 bit Linux).

@guruhb this is ready to integrate unless @johanvos wants to review it.

-------------

PR: https://git.openjdk.java.net/jfx/pull/97


[prev in list] [next in list] [prev in thread] [next in thread]