[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [Rev 17] RFR: 8236651: Simplify and update glass gtk backend
From:       Thiago Milczarek Sayao <tsayao () openjdk ! java ! net>
Date:       2020-01-29 19:07:30
Message-ID: 7pAm39WXpnEIFMQi2IlDJ7cyIv6m45uP1SUV40V1eEU=.3fd2d78e-791c-4a6c-b90e-511daf7cc4ae () github ! com
[Download RAW message or body]

> This proposed change does the following:
> 
> - Ports DND target to use GTK reducing code size and adding extra text / image \
>                 formats (such as .gif);
> - Use gtk signals instead of gdk events (also to reduce code size);
> - Simplifies geometry (sizing/positioning) with a more straightforward code (less \
>                 special cases), making it easier to understand and maintain;
> - Replaces (pointer and focus) grabbing with a gtk approach;
> - Reworked frame extents (the wm extension to get decoration sizes) to reduce size \
>                 and complexity;
> - Simplified cursor changing (for gtk3);
> - Reduced the use of gtk/gdk deprecated functions;
> - Removes Applet/Web Start code;
> - Fixes https://bugs.openjdk.java.net/browse/JDK-8237491;
> 
> In general it reduces code size and complexity and hands more work to gtk.
> 
> Updated on 2020-01-29:
> ![image](https://user-images.githubusercontent.com/30704286/73354728-2ce47d00-4275-11ea-935c-414fc26163d7.png)
> 

The pull request has been updated with 1 additional commit.

-------------

Added commits:
 - e829b8e9: Better fix for initial size

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/77/files
  - new: https://git.openjdk.java.net/jfx/pull/77/files/058a0992..e829b8e9

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/77/webrev.17
 - incr: https://webrevs.openjdk.java.net/jfx/77/webrev.16-17

  Stats: 12 lines in 2 files changed: 10 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jfx/pull/77.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/77/head:pull/77

PR: https://git.openjdk.java.net/jfx/pull/77


[prev in list] [next in list] [prev in thread] [next in thread]