[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag in DumpRenderTree
From:       Kevin Rushforth <kcr () openjdk ! java ! net>
Date:       2020-01-29 16:37:40
Message-ID: -SfKmye0pK6kJ2wqpasKM6lfUmo2EY2RvQC_1C7V5f0=.fb50dcfb-0c3c-4b3b-a5df-26fbf76e0ab3 () github ! com
[Download RAW message or body]

On Wed, 29 Jan 2020 16:32:31 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:

> > AnimationBase and WebAnimation are two different abstract animation API provider. \
> > By default KeyFrameAnimation (which is a sub class of AnimationBase) is used for \
> > controlling and rendering the CSS animation.  Enabling \
> > "WebAnimationsCSSIntegrationEnabled" overrides the CSSAnimationController to use \
> > WebAnimation which is not used in our port (JAVA) and we are using \
> > KeyFrameAnimation. 
> > Test : need to run DRT test harness with this fix for "LayoutTests/animations".
> 
> Marked as reviewed by kcr (Lead).

This fix only affects the test framework, so a single reviewer is fine.

-------------

PR: https://git.openjdk.java.net/jfx/pull/100


[prev in list] [next in list] [prev in thread] [next in thread]