[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [Rev 01] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture 
From:       Frederic Thevenet <github.com+7450507+fthevenet () openjdk ! java ! net>
Date:       2019-12-24 10:14:06
Message-ID: J8DrHueBIA88__j5zIlfqCWZyyJ6DhabHjCZPukpmA4=.a0323fd5-5484-4e6e-8065-3c1bde53785c () github ! com
[Download RAW message or body]

> This PR aims to address the following issue: JDK-8088198 Exception thrown from \
> snapshot if dimensions are larger than max texture size 
> In order to do that, it simply captures snapshots in multiple tiles of \
> maxTextureSize^2 dimensions (or less, as needed), and then recomposes all the tiles \
> into a a single image. Other than that, the logic used to do the actual snapshot is \
> unchanged. 
> Tests using the existing SnapshotCommon class have been added in a new file named \
> Snapshot3Test under SystemTest/test/javafx/scene. These tests pass with the \
> proposed fix, and fail without, throwing " java.lang.IllegalArgumentException: \
> Unrecognized image loader: null"

The pull request has been updated with 1 additional commit.

-------------

Added commits:
 - 9986809d: Revert formatting changes

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/68/files
  - new: https://git.openjdk.java.net/jfx/pull/68/files/4bc44173..9986809d

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/68/webrev.01
 - incr: https://webrevs.openjdk.java.net/jfx/68/webrev.00-01

  Stats: 17 lines in 1 file changed: 0 ins; 2 del; 15 mod
  Patch: https://git.openjdk.java.net/jfx/pull/68.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/68/head:pull/68

PR: https://git.openjdk.java.net/jfx/pull/68


[prev in list] [next in list] [prev in thread] [next in thread]