[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [Approved] RFR: 8200224: Multiple press event when JFXPanel gains focus
From:       Prasanta Sadhukhan <psadhukhan () openjdk ! java ! net>
Date:       2019-11-27 7:18:36
Message-ID: xOilmP39Q9bRPi61ZSmA4yvAUcA-J8miGk3UuCaegLg=.6ca6f868-a90c-4c88-a44a-c5d324893839 () github ! com
[Download RAW message or body]

On Tue, 26 Nov 2019 13:06:36 GMT, Florian Kirmaier <fkirmaier@openjdk.org> wrote:

> The pull request has been updated with additional changes.
> 
> ----------------
> 
> Added commits:
>  - 24385eb8: JDK-8200224
>  - e0829ad3: JDK-8200224
>  - c190384f: JDK-8200224
>  - 17b458b1: JDK-8200224
> 
> Changes:
>   - all: https://git.openjdk.java.net/jfx/pull/25/files
>   - new: https://git.openjdk.java.net/jfx/pull/25/files/44774dfb..24385eb8
> 
> Webrevs:
>  - full: https://webrevs.openjdk.java.net/jfx/25/webrev.04
>  - incr: https://webrevs.openjdk.java.net/jfx/25/webrev.03-04
> 
>   Issue: https://bugs.openjdk.java.net/browse/JDK-8200224
>   Stats: 141 lines in 2 files changed: 123 ins; 11 del; 7 mod
>   Patch: https://git.openjdk.java.net/jfx/pull/25.diff
>   Fetch: git fetch https://git.openjdk.java.net/jfx pull/25/head:pull/25

Looks good albeit with minor suggestion regarding presence of bugid in comment

----------------

Approved by psadhukhan (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/25
[prev in list] [next in list] [prev in thread] [next in thread]