[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation
From:       Nir Lisker <nlisker () openjdk ! org>
Date:       2019-10-30 10:36:39
Message-ID: jr0btvdWRhOq0xfR81aKpCD75sc-egxFuPQFPicjKbs=.7d986f71-d95f-4294-8d53-b82a083fcd2f () github ! com
[Download RAW message or body]

On Wed, 30 Oct 2019 10:27:28 GMT, Hadzic Samir <shadzic@openjdk.org> wrote:

> On Tue, 29 Oct 2019 14:38:10 GMT, Nir Lisker <nlisker@openjdk.org> wrote:
> 
> > On Wed, 9 Oct 2019 16:18:49 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:
> > 
> > > On Wed, 9 Oct 2019 16:11:49 GMT, Hadzic Samir <shadzic@openjdk.org> wrote:
> > > 
> > > > On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir <shadzic@openjdk.org> wrote:
> > > > 
> > > > > The pull request has been updated with additional changes.
> > > > > 
> > > > > ----------------
> > > > > 
> > > > > Added commits:
> > > > > - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for \
> > > > > clarification on TableColumnHeader 
> > > > > Changes:
> > > > > - all: https://git.openjdk.java.net/jfx/pull/6/files
> > > > > - new: https://git.openjdk.java.net/jfx/pull/6/files/969ebb51..e846e51c
> > > > > 
> > > > > Webrevs:
> > > > > - full: https://webrevs.openjdk.java.net/jfx/6/webrev.01
> > > > > - incr: https://webrevs.openjdk.java.net/jfx/6/webrev.00-01
> > > > > 
> > > > > Issue: https://bugs.openjdk.java.net/browse/JDK-8207957
> > > > > Stats: 27 lines in 3 files changed: 13 ins; 1 del; 13 mod
> > > > > Patch: https://git.openjdk.java.net/jfx/pull/6.diff
> > > > > Fetch: git fetch https://git.openjdk.java.net/jfx pull/6/head:pull/6
> > > > 
> > > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableColumnHeader.java \
> > > > line 608: 
> > > > > 607:     protected void resizeColumnToFitContent(int maxRows) {
> > > > > 608:         TableColumnBase<?, ?> tc = getTableColumn();
> > > > > 609:         if (!tc.isResizable()) return;
> > > > 
> > > > I have put the `since 14`, because if merged, it will be available in OpenJFX \
> > > > 14 right? (It was 13 before)
> > > 
> > > Correct.
> > 
> > The "The resulting column width for this implementation..." part might belong in \
> > an `@implSpec` section.
> 
> From https://openjdk.java.net/jeps/8068562
> 
> > Implementation Specification. This is where the default implementation (or an \
> > overrideable implementation in a class) is specified. Interface implementors or \
> > class subclassers use the information here in order to decide whether it is \
> > sensible or necessary to override a particular method, and what behavior they can \
> > rely on if a method is called via super.
> 
> So maybe the whole part beginning from "The resulting column [..]width etc.)." \
> should be in the `@implSpec` section.

Yes.

PR: https://git.openjdk.java.net/jfx/pull/6


[prev in list] [next in list] [prev in thread] [next in thread]