[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8200224: Multiple press event when JFXPanel gains focus
From:       Florian Kirmaier <github.com+6547435+FlorianKirmaier () openjdk ! org>
Date:       2019-10-29 16:27:17
Message-ID: vnIum3GPAPk_idkRB-2-WN4oeIkta7MKc5EOqvpHtbA=.8ee0ca60-8bcf-46da-a82c-d30cabdedf39 () github ! com
[Download RAW message or body]

On Tue, 29 Oct 2019 15:59:58 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:

> On Tue, 29 Oct 2019 15:48:46 GMT, Florian Kirmaier \
> <github.com+6547435+FlorianKirmaier@openjdk.org> wrote: 
> > On Tue, 29 Oct 2019 14:47:19 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:
> > 
> > > On Tue, 29 Oct 2019 14:45:46 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:
> > > 
> > > > On Tue, 29 Oct 2019 11:27:35 GMT, Florian Kirmaier \
> > > > <github.com+6547435+FlorianKirmaier@openjdk.org> wrote: 
> > > > > Original PR: https://github.com/javafxports/openjdk-jfx/pull/591
> > > > > 
> > > > > A side effect of JDK-8200224 is, that the first click on a JFXPanel is \
> > > > > always a double click. The cause for JDK-8200224 is the fix for JDK-8087914 \
> > > > > (Clicking on Menu in JFXPanel ignored if another swing component has \
> > > > > focus). This fix introduced synthesized press-events, which is an unsafe \
> > > > > fix for the problem. 
> > > > > The pull request introduces a new fix for the problem.
> > > > > Instead of simulating new input-events, we set JavaFX Scene/Window to \
> > > > > focused. We do so, by using setFocused.
> > > > > When the original Swing-Focus event is called slightly later, it won't have \
> > > > > any side-effects, because calling setFocused just sets the value of a \
> > > > > boolean property. 
> > > > > I've now also added a unit-test for the problem.
> > > > > 
> > > > > ----------------
> > > > > 
> > > > > Commits:
> > > > > - 314e423c: JDK-8200224
> > > > > - 725e5fef: JDK-8200224
> > > > > 
> > > > > Changes: https://git.openjdk.java.net/jfx/pull/25/files
> > > > > Webrev: https://webrevs.openjdk.java.net/jfx/25/webrev.00
> > > > > Issue: https://bugs.openjdk.java.net/browse/JDK-8200224
> > > > > Stats: 140 lines in 2 files changed: 133 ins; 2 del; 5 mod
> > > > > Patch: https://git.openjdk.java.net/jfx/pull/25.diff
> > > > > Fetch: git fetch https://git.openjdk.java.net/jfx pull/25/head:pull/25
> > > > 
> > > > @FlorianKirmaier you still need to file a JBS issue to associate your GitHub \
> > > > username with your OpenJDK user ID as noted [above](#issuecomment-546883472), \
> > > > and per the instructions in [this \
> > > > message](https://mail.openjdk.java.net/pipermail/openjfx-dev/2019-September/023558.html) \
> > > > sent to openjfx-dev.
> > > 
> > > @prsadhuk please review this. I will also review it (this will need two \
> > > reviewers).
> > 
> > @kevinrushforth 
> > If created the ticket a moment ago. \
> > https://bugs.openjdk.java.net/browse/JDK-8233121 Is this okay, or is any \
> > information missing?
> 
> > https://bugs.openjdk.java.net/browse/JDK-8233121
> 
> It was created in the JDK Project rather than the SKARA project (odd...the link \
> should have filled in the right project and component). I fixed it.

Great, thanks.

Some more notes on the importance of this Change.
A project which uses a lot of JFXPanels for small components was basically unusable \
because the majority of clicks were registered as a double click. This made the \
software basically unusable with JavaFX11.

PR: https://git.openjdk.java.net/jfx/pull/25


[prev in list] [next in list] [prev in thread] [next in thread]