[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8087980: Add property to disable Monocle cursor
From:       Kevin Rushforth <kcr () openjdk ! org>
Date:       2019-10-29 11:31:18
Message-ID: h9Gzqr1wCVIEvQwACoMGAilTeIbstIwbtQKdW_Ikess=.f1146374-6a97-4c2f-8819-ca16c0073c60 () github ! com
[Download RAW message or body]

On Tue, 29 Oct 2019 10:10:32 GMT, Dell Green \
<github.com+12861109+dellgreen@openjdk.org> wrote:

> On Tue, 29 Oct 2019 09:53:28 GMT, Johan Vos <jvos@openjdk.org> wrote:
> 
> > On Tue, 8 Oct 2019 12:03:46 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:
> > 
> > > On Tue, 8 Oct 2019 12:03:42 GMT, Dell Green \
> > > <12861109+dellgreen@users.noreply.github.com> wrote: 
> > > > Often on embedded systems a cursor is not a valid input modality. On some of \
> > > > these systems, when the javafx toolkit initialises the native hardware \
> > > > cursor, it produces artefacts which can be seen on screen (in the framebuffer \
> > > > for example). This change adds a system property "monocle.cursor.enabled" \
> > > > that can disable the creation of a native cursor in each of the Monocle \
> > > > NativePlatform implementations in favour of a NullCursor which is a no-op \
> > > > implementation of the NativeCursor abstract class that all native cursors \
> > > > have to implement. 
> > > > NullCursor class already existed and was being returned for some \
> > > > implementations like AndroidPlatform and HeadlessPlatform. This change builds \
> > > > upon that and conditionally returns NullCursor for all platforms. 
> > > > A system property "monocle.debugcursor" has also been added to turn on \
> > > > logging of which NativeCursor has been selected when the toolkit initialises. \
> > > >                 
> > > > ----------------
> > > > 
> > > > Commits:
> > > > - cfbbc7dd: JDK-8087980: Add property to disable Monocle cursor
> > > > 
> > > > Changes: https://git.openjdk.java.net/jfx/pull/5/files
> > > > Webrev: https://webrevs.openjdk.java.net/jfx/5/webrev.00
> > > > Issue: https://bugs.openjdk.java.net/browse/JDK-8087980
> > > > Stats: 49 lines in 8 files changed: 40 ins; 0 del; 9 mod
> > > > Patch: https://git.openjdk.java.net/jfx/pull/5.diff
> > > > Fetch: git fetch https://git.openjdk.java.net/jfx pull/5/head:pull/5
> > > 
> > > This has not yet been reviewed. It will need at least one reviewer with a \
> > > Reviewer role in the project. 
> > > ----------------
> > > 
> > > Disapproved by kcr (Lead).
> > 
> > Is this PR open for review now? Or will a new PR be created?
> 
> this is ready for review form my perspective. :)

The Skara tooling bug in question has been fixed, so yes this is ready for review.

PR: https://git.openjdk.java.net/jfx/pull/5


[prev in list] [next in list] [prev in thread] [next in thread]