[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: JDK-8090930: Add Support for Extended Mouse Buttons
From:       Kevin Rushforth <kevin.rushforth () oracle ! com>
Date:       2018-10-30 22:17:13
Message-ID: 5b2ede53-8a62-2baa-00db-75667a737e88 () oracle ! com
[Download RAW message or body]

I don't have a strong opinion. On the one hand, the platform libraries 
(at least Mac and Windows) use some variation of BUTTON4 and BUTTON5 
rather than a name. On the other hand, we already use symbolic names for 
the PRIMARY, SECONDARY, and MIDDLE buttons, rather than using 1, 2, 3. 
I'm OK with the symbolic names FORWARD and BACK, but I also see Johan's 
point.

-- Kevin


On 10/30/2018 12:33 PM, Michael Ennen wrote:
> Great question. It seems to be pretty standard that mouse buttons 4 and 5
> are called
> back and forward. So either way would be fine with me. In my opinion the
> descriptive
> names may be better as then EventListeners responding to these new buttons
> would
> be more human-readable.
>
> On Tue, Oct 30, 2018 at 5:15 AM Johan Vos <johan.vos@gluonhq.com> wrote:
>
>> Hi Michael,
>>
>> I only started to look into this now, sorry for being late at the party.
>> Overall, this looks good to me. The risk is indeed minimal (developers
>> relying on switch-default cases to select e.g. middle button will be
>> punished).
>>
>> I am not entirely sure about the naming though. Should it really be
>> "BACK/FORWARD" or should it rather be "BUTTON4/BUTTON5" as it can be mapped
>> to whatever?
>>
>> - Johan
>>
>> On Thu, Aug 30, 2018 at 12:54 AM Michael Ennen <mike.ennen@gmail.com>
>> wrote:
>>
>>> Hello All,
>>>
>>> I am working on JDK-8090930 which is a request to add
>>> support for the BACK/FORWARD mouse buttons that are
>>> supported by some mice. I have opened a proof-of-concept
>>> pull request on Github which can be found here:
>>>
>>> https://github.com/javafxports/openjdk-jfx/pull/173
>>>
>>> This is still in the early stages (no CSR has been created yet,
>>> however there is a preliminary one in the comments on the
>>> above Github issue) but Kevin wanted me to post a notification
>>> to this list so that people can review and comment on it (and
>>> I think that's a good idea, too).
>>>
>>> Thanks,
>>>
>>> Michael Ennen
>>>

[prev in list] [next in list] [prev in thread] [next in thread]