[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [8u-backport] JDK-8212147: [JavaFX] Conditional support for GTK 3 on Linux
From:       Kevin Rushforth <kevin.rushforth () oracle ! com>
Date:       2018-10-25 13:54:14
Message-ID: 3a4807ec-3b76-fd70-37ab-86812fddf631 () oracle ! com
[Download RAW message or body]

+1

As with last time, this will need a second reviewer before pushing it to 
8u-dev.

-- Kevin


On 10/23/2018 9:59 AM, Pankaj Bansal wrote:
>
> Hi All,
>
> Please review the patch for 8u-dev backport for JDK-8087516 
> <https://bugs.openjdk.java.net/browse/JDK-8087516>. It adds 
> conditional support for gtk3.
>
> As part of the enhancement backport, we will be backporting 18 more 
> bugs fixes done for GTK3 related issues since jdk9. Due to this, the 
> backport will be pushed under 
> https://bugs.openjdk.java.net/browse/JDK-8212147. More information 
> about the 18 bugs can be found at 
> https://bugs.openjdk.java.net/browse/JDK-8212147.
>
> The https://bugs.openjdk.java.net/browse/JDK-8212147 is a re-creation 
> of https://bugs.openjdk.java.net/browse/JDK-8206246. The fix for 
> https://bugs.openjdk.java.net/browse/JDK-8206246 was backed out under 
> https://bugs.openjdk.java.net/browse/JDK-8212139 due to some build 
> issues. Those issues have been resolved and now this fix can be pushed.
>
> Under https://bugs.openjdk.java.net/browse/JDK-8206246 the approved 
> version was 01 [1]. We have removed some un-used code, which was added 
> by mistake as it was moved under gtk3 work and bug fixes. There is no 
> change in functionality though. The updated webrev is version 02 [2]. 
> Only following files have been changed in version 02 as compared to 01.
>
> 1.modules/graphics/src/main/native-glass/gtk/glass_general.cpp
>
> 2.modules/graphics/src/main/native-glass/gtk/glass_general.h
>
> 3.modules/graphics/src/main/native-glass/gtk/wrapped.c
>
> 4.modules/graphics/src/main/native-glass/gtk/wrapped.h
>
> webrev: 
> http://cr.openjdk.java.net/~pbansal/gtk3_JFX_backport/webrev.02/ 
> <http://cr.openjdk.java.net/%7Epbansal/gtk3_JFX_backport/webrev.02/>
>
> Enhancement under which this change will be pushed: 
> https://bugs.openjdk.java.net/browse/JDK-8212147
>
> JDK 9 Enhancement: https://bugs.openjdk.java.net/browse/JDK-8087516
>
> JDK 9 Changeset: 
> http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/8c6d0386d3f5
>
> [1] http://cr.openjdk.java.net/~pbansal/gtk3_JFX_backport/webrev.01/ 
> <http://cr.openjdk.java.net/%7Epbansal/gtk3_JFX_backport/webrev.01/>
>
> [2] http://cr.openjdk.java.net/~pbansal/gtk3_JFX_backport/webrev.02/ 
> <http://cr.openjdk.java.net/%7Epbansal/gtk3_JFX_backport/webrev.02/>
>
> Regards,
>
> Pankaj
>

[prev in list] [next in list] [prev in thread] [next in thread]