[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [11] Review request: 8200446: Update minimum boot JDK to 10
From:       Kevin Rushforth <kevin.rushforth () oracle ! com>
Date:       2018-06-14 14:25:54
Message-ID: 9dbe7169-bf1a-f351-346f-a0a03d4f636a () oracle ! com
[Download RAW message or body]

Thanks for the reminder. This is good advice that we should all strive 
to follow.

-- Kevin

On 6/14/2018 6:37 AM, Nir Lisker wrote:
>
>     Once this is done, we can start using JDK 10 features, such as
>     'var' for local variables (although please don't take this as a
>     license to use 'var' gratuitously).
>
>
> I'll remind that there's a style guide at 
> http://openjdk.java.net/projects/amber/LVTIstyle.html.
>
> - Nir
>
> On Thu, Jun 14, 2018 at 4:33 PM, Kevin Rushforth 
> <kevin.rushforth@oracle.com <mailto:kevin.rushforth@oracle.com>> wrote:
>
>     Please review the following to bump the minimum boot JDK required
>     for JavaFX builds to JDK 10. Note that the review will be done on
>     github, but it is OK to reply to this thread with comments if you
>     don't have a github account.
>
>     https://bugs.openjdk.java.net/browse/JDK-8200446
>     <https://bugs.openjdk.java.net/browse/JDK-8200446>
>     https://github.com/javafxports/openjdk-jfx/pull/61
>     <https://github.com/javafxports/openjdk-jfx/pull/61>
>
>     This also bumps the class file format to that of JDK 10. I note
>     that we have been using JDK 10 to build the openjfx-11 builds for
>     several months, and now that we've upgraded to gradle 4.8 we are
>     ready to make JDK 10 the minimum.
>
>     Once this is done, we can start using JDK 10 features, such as
>     'var' for local variables (although please don't take this as a
>     license to use 'var' gratuitously).
>
>     Thanks.
>
>     -- Kevin
>
>

[prev in list] [next in list] [prev in thread] [next in thread]