[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: OpenJFX GitHub mirror
From:       Nir Lisker <nlisker () gmail ! com>
Date:       2018-03-29 12:13:03
Message-ID: CA+0ynh8e8j0Ke8-rZpYQ+=JXbCsYFoN=nMhtzqWdBejbspqwaw () mail ! gmail ! com
[Download RAW message or body]

I think that the labels should be succinct, so one label should suffice.
Either github-link or github-bug are fine for me, the latter because there
is webbug label already. If a PR needs review just use the review-request
existing label.

As for issues and PRs, the issue links section in the JIRA ticket could
reflect what exists in GitHub, so there can be 2 web links named "GitHub
issue" and "GitHub PR" if need be.

- Nir

On Thu, Mar 29, 2018 at 10:08 AM, Tom Schindl <tom.schindl@bestsolution.at>
wrote:

> well could we have 2:
> * github-issue
> * github-pr
>
> The first one indicates someone is working on it over at github, whereas
> the second means there's a PR that needs to be review.
>
> Tom
>
> On 29.03.18 08:42, Laurent Bourg=C3=A8s wrote:
> > Hi,
> >
> > As such github references point to either issue or PR, I recommend usin=
g
> > the term 'github-link'.
> >
> > Laurent
> >
> > Le jeu. 29 mars 2018 =C3=A0 03:40, Kevin Rushforth <
> kevin.rushforth@oracle.com>
> > a =C3=A9crit :
> >
> >> I think this would be fine. We would want something that didn't confli=
ct
> >> with anything else and wasn't confusing. Possible choices:
> >>
> >> github-link
> >> github-bug
> >> gitbug-issue
> >>
> >> Any preferences?
> >>
> >> -- Kevin
> >>
> >>
> >> Nir Lisker wrote:
> >>> Kevin, can we get a label for this?
> >>>
> >>> - Nir
> >>>
> >>> On Mon, Mar 26, 2018 at 4:37 PM, Johan Vos <johan.vos@gluonhq.com>
> >> wrote:
> >>>
> >>>
> >>>> Hi Nir,
> >>>>
> >>>> About 4. (jfx-dev): you're right, I just removed that repository. Th=
at
> >> was
> >>>> just some testing before we did the real thing.
> >>>>
> >>>> As for the other points: I agree
> >>>>
> >>>> - Johan
> >>>>
> >>>> On Mon, Mar 26, 2018 at 12:03 PM Nir Lisker <nlisker@gmail.com>
> wrote:
> >>>>
> >>>>
> >>>>> Hi All,
> >>>>>
> >>>>> A few comments about the mirror and JBS:
> >>>>>
> >>>>> 1. In PRs and issues on GitHub, I strongly suggest that the link to
> >> JBS be
> >>>>> included in the top comment. If the JBS issue was created after a
> >>>>> discussion, edit it in.
> >>>>>
> >>>>> 2. In JBS, I suggest to link to the GitHub mirror via More > Link >
> Web
> >>>>> Link and in the Link Text use something like "GitHub mirror" (open
> for
> >>>>> suggestions). JIRA renders the link in an easy to see way (easier
> than
> >>>>> looking at URLs). Iv'e tried it in a couple of issues, e.g.,
> >>>>> https://bugs.openjdk.java.net/browse/JDK-8198795 and it seems
> >> preferable
> >>>>> to
> >>>>> me.
> >>>>>
> >>>>> 3. In JBS, I suggest a new label will be used for issues which are
> >> linked
> >>>>> to GitHub for search purposes. This is similar to the webbug label.
> >>>>>
> >>>>> If these are agreeable, please add them to the contribution
> >> instructions.
> >>>>>
> >>>>> 4. What is https://github.com/javafxports/jfx-dev? Newcomers can
> >> confuse
> >>>>> it
> >>>>> with javafxports/openjdk-jfx.
> >>>>>
> >>>>> 5. When the mirror is fully ready and operational, we should
> advertise
> >> on
> >>>>> community pages (like Reddit) to gather up contributors. Please kee=
p
> a
> >>>>> mental reminder when the time comes.
> >>>>>
> >>>>> Thanks to all who are working on this.
> >>>>>
> >>>>> - Nir
> >>>>>
> >>>>>
> >>
>
[prev in list] [next in list] [prev in thread] [next in thread]