[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: Proposal For Inclusion of Robot and ParametersImpl in the Public API
From:       Kevin Rushforth <kevin.rushforth () oracle ! com>
Date:       2018-03-26 21:25:27
Message-ID: 5AB96547.8080204 () oracle ! com
[Download RAW message or body]

Seems a reasonable addition to me, too.

-- Kevin


Michael Ennen wrote:
> Sounds like a reasonable idea to me.
>
> On Mon, Mar 26, 2018 at 1:00 PM, Nir Lisker <nlisker@gmail.com> wrote:
>
>   
>> I'm thinking about the addition of a public method for mouse click, which
>> is mouse press and then mouse release - the parallel for key typed. Is it
>> worth?
>>
>> - Nir
>>
>> On Mon, Mar 26, 2018 at 5:54 PM, Kevin Rushforth <
>> kevin.rushforth@oracle.com> wrote:
>>
>>     
>>> Seems good to me, too.
>>>
>>> -- Kevin
>>>
>>>
>>> Michael Ennen wrote:
>>>
>>>       
>>>> Sounds like a good idea to me to only have `getScreenCapture` methods
>>>> that have a WritableImage parameter which can be `null` which means a
>>>> new WritableImage will be created otherwise the given one is re-used, as
>>>> in Scene.snapshot and Node.snapshot. What are your thoughts on this,
>>>> Kevin?
>>>>
>>>> On Sat, Mar 24, 2018 at 6:11 PM, Scott Palmer <swpalmer@gmail.com
>>>> <mailto:swpalmer@gmail.com>> wrote:
>>>>
>>>>
>>>>
>>>>     On Mar 23, 2018, at 5:50 PM, Michael Ennen <mike.ennen@gmail.com
>>>>         
>>>>>     <mailto:mike.ennen@gmail.com>> wrote:
>>>>>
>>>>>     Kevin,
>>>>>
>>>>>     I believe I followed all of your suggestions, except the one with a
>>>>>     re-usable WritableImage.
>>>>>     If you want me to implement that as well, I can, but you seemed
>>>>>     unsure
>>>>>     about the necessity
>>>>>     of it.
>>>>>
>>>>>           
>>>>     I think it should be included to reduce garbage generated in a
>>>>     case where repeated captures is used.  Such as a desktop sharing
>>>>     application, a screen recorder, etc.
>>>>     It would also be consistent with the node.snapshot API.
>>>>
>>>>     In fact, I would just have the version that takes a WriteableImage
>>>>     and match the behaviour of node.snapshot.
>>>>
>>>>     Scott
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Michael Ennen
>>>>
>>>>         
>
>
>   
[prev in list] [next in list] [prev in thread] [next in thread]