[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [11] Review Request: JDK-8167096 RFE: change the default INITIAL_DURATION_MS to match the behavi
From:       Kevin Rushforth <kevin.rushforth () oracle ! com>
Date:       2018-01-15 15:41:50
Message-ID: 5A5CCBBE.7080505 () oracle ! com
[Download RAW message or body]

Hi Prem,

Since this adds new API, this needs a CSR. In general it is best to get 
any proposed API additions reviewed on this alias before spending much 
time on it. In this case, the newly proposed API is a simple property, 
and is the obvious solution, so the API itself looks fine.

Can you please file the CSR? The code review can proceed in parallel 
with the CSR review.

-- Kevin


Prem Balakrishnan wrote:
>
> Hi Kevin, Ajit
>
>  
>
> Request you to review following fix:
>
>  
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8167096  
>
>  
>
> Webrev:  http://cr.openjdk.java.net/~pkbalakr/fx/8167096/webrev00/ 
> <http://cr.openjdk.java.net/%7Epkbalakr/fx/8167096/webrev00/>
>
>  
>
> Regards,
>
> Prem
>
>  
>
[prev in list] [next in list] [prev in thread] [next in thread]