[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [10] RFR JDK-8189280:Memory leak in SwingNode if Stage is not shown
From:       Prasanta Sadhukhan <prasanta.sadhukhan () oracle ! com>
Date:       2017-11-27 9:10:48
Message-ID: 9d935a1b-6483-9690-7236-7c8203c2ceea () oracle ! com
[Download RAW message or body]

Removed commented code in-place

Regards
Prasanta
On 11/27/2017 1:20 PM, Jayathirth D V wrote:
> Hi Prasanta,
> 
> In the test case please add reason why you have kept commented code like :
> //public static void main(String[] args) {
> //    Application.launch(args);
> //}
> 
> //@Override
> //public void start(Stage primaryStage) {
> //    memoryLeakTest();
> //}
> 
> Also please resolve indentation problem in comments like:
> 
> //stage.show();
> //        tk.firePulse();
> 
> //        tk.firePulse();
> 
> Thanks,
> Jay
> -----Original Message-----
> From: Prasanta Sadhukhan
> Sent: Monday, November 27, 2017 1:08 PM
> To: Kevin Rushforth; openjfx-dev@openjdk.java.net Mailing
> Subject: [10] RFR JDK-8189280:Memory leak in SwingNode if Stage is not shown
> 
> Hi All,
> 
> Please review a swingnode memory leak fix for fx \
> http://cr.openjdk.java.net/~psadhukhan/fx/8189280/webrev.00/ for issue
> https://bugs.openjdk.java.net/browse/JDK-8189280
> 
> More info in JBS.
> 
> Regards
> Prasanta


[prev in list] [next in list] [prev in thread] [next in thread]