[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [10] Review request for 185634: Java Fx-Swing dialogs appearing behind main stage
From:       Phil Race <philip.race () oracle ! com>
Date:       2017-09-21 16:55:27
Message-ID: c10968d7-af0b-d599-6620-dd95e4d7af12 () oracle ! com
[Download RAW message or body]

Some procedural comments :
Since 90% of this is in AWT code, I'd have thought awt-dev should be 
included here.
I've added that list.

And apart from needing separate bug ids, I don't see why the bug below 
is confidential.


I agree with what Kevin pointed out off-line that as in the dialog case, 
the FX side
of the code can use reflection and simply be a harmless non-functional no-op
if the SwingAccessor does not provide the new method.

BTW

264 inline HWND GetOverridenHWnd() { return m_overridenHwnd; }

should be "dd" not "d".

-phil.

On 09/21/2017 03:38 AM, Alexander Zvegintsev wrote:
> Hello,
>
> please review the fix
>
> http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/00/
>
> for the issue
>
> https://bugs.openjdk.java.net/browse/JDK-8185634
>

[prev in list] [next in list] [prev in thread] [next in thread]