[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [PATCH] 8182572 Numpad keys not working with JavaFX Monocle
From:       Johan Vos <johan.vos () gluonhq ! com>
Date:       2017-09-21 10:12:19
Message-ID: CABxFH2GgB_vi64Pu8F795tk+2txzB7G33mXJasVE8wLd1dKcHA () mail ! gmail ! com
[Download RAW message or body]

That patch looks ok for me, and it doesn't break anything in the Android
build (the other consumer of Monocle).

- Johan

On Wed, Sep 20, 2017 at 6:45 PM Milan Fabian <mimac2@gmail.com> wrote:

> Hello,
>
> I have prepared patch (attached) for bug JDK-8182572 (
> http://bugs.java.com/
> bugdatabase/view_bug.do?bug_id=JDK-8182572
> <http://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8182572>). The
> keys on numpad are now
> correctly mapped to KeyEvents.
>
> The patch was tested on Raspberry Pi with various builds OpenJDK 8 and
> various keyboards. I don't have any other device which supports Monocle, if
> anybody has such device, I would be glad if you could test it on it as
> well.
>
> As this is my first patch submitted to OpenJDK, is there anything else I
> should add?
>
> Best Regards
> Milan Fabian
>
[prev in list] [next in list] [prev in thread] [next in thread]