[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [10] RFR: JDK-8133329: Drag and Drop of files in a SwingNode fails
From:       Jim Graham <james.graham () oracle ! com>
Date:       2017-08-05 0:06:10
Message-ID: a0deaac9-ef93-bfcb-5106-938125fc2ce4 () oracle ! com
[Download RAW message or body]

This looks good... +1

			...jim

On 8/3/17 9:20 PM, Prasanta Sadhukhan wrote:
> 
> 
> On 8/4/2017 2:57 AM, Jim Graham wrote:
> > I noticed a "FIXME" comment in there.  Didn't we do a pass a while back and \
> > convert all of them into JBS entries? 
> > The new code simply repeats what was done for the existing Exception which is \
> > what has the "FIXME" comment so I would  use this opportunity to upgrade that \
> > FIXME into an actual bug entry. 
> > Also, perhaps we could use the multi-catch syntax here instead of creating a new \
> > catch? 
> Ok. I have put it as a mult-catch in this webrev
> http://cr.openjdk.java.net/~psadhukhan/fx/8133329/webrev.01/
> 
> Regards
> Prasanta
> > ...jim
> > 
> > On 8/3/17 2:01 AM, Prasanta Sadhukhan wrote:
> > > Hi All,
> > > 
> > > Please review a fix
> > > http://cr.openjdk.java.net/~psadhukhan/fx/8133329/webrev.00/
> > > for issue
> > > https://bugs.openjdk.java.net/browse/JDK-8133329
> > > More information in JBS.
> > > 
> > > Regards
> > > Prasanta
> 


[prev in list] [next in list] [prev in thread] [next in thread]