[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [9] Review request: 8178015: Clarify requirement for app modules to export/open packages to java
From:       Kevin Rushforth <kevin.rushforth () oracle ! com>
Date:       2017-04-21 23:14:37
Message-ID: 58FA925D.2060903 () oracle ! com
[Download RAW message or body]

OK. I'll make that change as part of JDK-8177341.

-- Kevin


Alex Buckley wrote:
> Yes, I recommend not pointing ordinary consumers of JavaFX to 
> java.lang.reflect.Module::add* methods. If open-ness is ever mentioned 
> (and as you know, I do like it to be acknowledged), then it can be 
> parenthetical.
>
> Alex
>
> On 4/21/2017 4:08 PM, Kevin Rushforth wrote:
>> OK, so you recommend changing module-info.class to module-info.java and
>> removing the reference to Module#addExports entirely, right? I can fix
>> this as part of a general cleanup JBS issue [1] that is left open to
>> pick up various typos, etc.
>>
>> Would you recommend the same for the FXML annotation, and not refer them
>> to Module#addOpens?
>>
>> -- Kevin
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8177341
>>
>>
>> Alex Buckley wrote:
>>> On 4/20/2017 11:06 AM, Kevin Rushforth wrote:
>>>> Additionally, I removed the example in the FXML annotation showing the
>>>> use of "opens to" in module-info.java (but left the example in
>>>> Application).
>>>
>>> Similar to my private comments to you on a related matter:
>>>
>>> Recommend straightforwardness: "... the module must export (or open)
>>> the containing package to at least the javafx.graphics module. [NEW
>>> PARAGRAPH] For example, ..."
>>>
>>> I don't get the desire to always rotate towards module-info._class_
>>> and Module#addExports when the focus should be on ordinary source code.
>>>
>>> Alex
[prev in list] [next in list] [prev in thread] [next in thread]