[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    FW: [9] Review request for 8133775 : Some WebNode tests crash JVM
From:       Ankit Srivastava <a.ankit.srivastava () oracle ! com>
Date:       2016-02-23 8:35:45
Message-ID: 20d71af5-1cf6-4599-8558-3c11b8a4a500 () default
[Download RAW message or body]

 

Hi Murali, Kevin, Alexander,

 

Please review the webrev :

http://cr.openjdk.java.net/~arajkumar/ankit/8133775/webrev.00/

 

JBS:

https://bugs.openjdk.java.net/browse/JDK-8133775

 

Changes:

1)      Made "checkEventThread()" function public to make it accessible to JSObject \
class which is in different package and is not a derived class of Invoker.

2)      Added check to throw exception instead of JVM crash if functions are called \
from non-jfx thread.

Reference : https://docs.oracle.com/javafx/2/api/javafx/scene/web/WebEngine.html

 

         Verified on  Linux  64 machine with changes , exception is being thrown \
instead of JVM crash.

         On Windows 64  JVM doesn't crash previously, with code changes exception \
will be thrown.

 

Regards,

Ankit

 

 


[prev in list] [next in list] [prev in thread] [next in thread]