[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [Review request] 8088853: Applying dashed border to separator makes whole application hang
From:       Jim Graham <james.graham () oracle ! com>
Date:       2016-02-17 20:05:04
Message-ID: 56C4D270.7000205 () oracle ! com
[Download RAW message or body]

Looks great.  Approved...

			...jim

On 2/17/2016 1:11 AM, Andrey Rusakov wrote:
> Updated that:
> <http://cr.openjdk.java.net/%7Earusakov/8088853/webrev.01>http://cr.ope=
njdk.java.net/~arusakov/8088853/webrev.01
>
> 17.02.2016 01:22, Jim Graham =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>> [I believe you sent this to the wrong mailing list - the "-request"
>> list is for changing your membership to the mailing list, not for
>> sending mail to the list itself.  I fixed it here in my reply...]
>>
>> That looks fine.  I'll note that the "dashCumulative" variable does
>> not need to be computed if you don't recompute the gapLength at line
>> 1580, so that line (#1578) can be moved inside the if statement.
>>
>> Other than that, it looks good...
>>
>>             ...jim
>>
>> On 2/15/2016 2:50 AM, Andrey Rusakov wrote:
>>> Hello, everyone! Could you look at my fix for JDK-8147944?
>>> http://cr.openjdk.java.net/~arusakov/8088853/webrev.00
>
[prev in list] [next in list] [prev in thread] [next in thread]