[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    review for SceneBuilder run
From:       David Hill <David.Hill () Oracle ! com>
Date:       2015-05-27 15:29:22
Message-ID: 5565E2D2.1060206 () Oracle ! com
[Download RAW message or body]

jira: https://javafx-jira.kenai.com/browse/RT-4014
webrev: http://cr.openjdk.java.net/~ddhill/RT-40140 \
<http://cr.openjdk.java.net/%7Eddhill/RT-40140>

Kevin,

This works - but does not make complete sense to me.
I am setting a default setting of:

<!-- usually set by the build -->
<property name="platforms.JDK_1.8.home" location="${java.home}/../"/>

which is used/accepted by the samples subdir, but not by SceneBuilderKit, \
SceneBuilderAPP, where I had to add the above lines again. I would have thought that \
the inheritAll="true" would work for all of them, but something is getting in the \
way.

As I have put more time into this than I expected, I am proposing this change.

Tested with:
    * JAVA_HOME set to a full JDK (ant clean run)
    * within the build on Mac and Linux. (gradle apps)

-- 
David Hill<David.Hill@Oracle.com>
Java Embedded Development

"A man's feet should be planted in his country, but his eyes should survey the \
                world."
-- George Santayana (1863 - 1952)


[prev in list] [next in list] [prev in thread] [next in thread]