[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Syntax for image-pattern support in CSS
From:       richard.bair () oracle ! com (Richard Bair)
Date:       2012-08-31 22:36:01
Message-ID: F8A3A478-5D27-463A-BF7F-448C6C086337 () oracle ! com
[Download RAW message or body]

Never mind me, it has been a long day :-). Of course the repeating-image-pattern \
function solves my problem. So I will simply do:

image-pattern(<uri-string>[,<size>,<size>,<size>,<size>[,<boolean>]?]?)
repeating-image-pattern(<uri-string>)

In the case of image-pattern, the uri-string is mandatory, and we default to 0%, 0%, \
100%, 100%, true (just like the constructor). You can just specify the numbers and \
not bother with the boolean if you want. You only have to specify the boolean if you \
need to specify the numbers and have it not be proportional.

For the tiling case, just use repeating-image-pattern and be happy.

Seems great.

Richard

On Aug 31, 2012, at 3:25 PM, Richard Bair wrote:

> Sounds good, I am updating the parser. It does irritate me that proportional is \
> true by default, just because it means that the tiling case (probably the most \
> common case) requires the long form. I wouldn't want the inconsistency from CSS to \
> constructors though. What bothers me is that giving the anchor meaning is kind of \
> unnecessary most of the time, because all you want to do is have the image at its \
> intrinsic width/height tiled. But you have to hard code sizes in this call in CSS, \
> don't you? 
> As far percent, I agree that would be nicer than 0-1. However, I'm not sure how to \
> make it sensible with that final boolean. I could just say that 0% == 0, and 100% \
> == 1. The final boolean could be optional since it defaults to true. You have to \
> specify the long form if you want it to tile. Irritating, but not the end of the \
> world. 
> Richard
> 
> On Aug 31, 2012, at 6:15 AM, David Grieve wrote:
> 
> > Instead of url, I'd prefer both be image-pattern, since ImagePattern has a ctor \
> > taking just the image. Syntax would be 
> > image-pattern(<string>[,<number>,<number>,<number>,<number>,<boolean>]?)
> > 
> > which, as you mention, maps 1-1 onto ImagePattern. The problem here, though, is \
> > how to get tiling without knowing the size of the image since the ImagePattern \
> > default is stretch. You propose a url syntax.  Will people be confused by this? I \
> > suggest a function  
> > repeating-image-pattern(<string>)
> > 
> > which gets you the repeat. This is unambiguous and follows what W3C does for \
> > gradients (e.g., repeating-radial-gradient). 
> > 
> > On Aug 30, 2012, at 9:20 PM, Richard Bair wrote:
> > 
> > > http://javafx-jira.kenai.com/browse/RT-19455
> > > 
> > > Anywhere a Paint is allowed:
> > > 
> > > url('region/test20x20.png');
> > > image-pattern('region/test20x20.png', 0, 0, 1, 1, true);
> > > 
> > > The syntax is exactly the same as our ImagePattern class. I rather chose the \
> > > rgb() style function rather than linear, radial gradient style named parameters \
> > > both because it was less work and less syntax to define, and because there \
> > > aren't many params and I thought I'd just map directly to the class. I could \
> > > have tried giving percentage based value support (percent of what? The image, \
> > > the dest?) but I decided to just stick with plain numbers. Most of the time \
> > > people will either just use the url version and get tiling for free, or they \
> > > will use the image-pattern version and get it stretched (as I've done here). Or \
> > > they can do whatever with the image-pattern version. 
> > > What do you think?
> > > 
> > > (I'm attacking this issue right now, incidentally, because I'm working on \
> > > numerous Region performance and behavior issues, and in my travels I noticed \
> > > some very useful rendering modes are not supported currently with respect to \
> > > images, so I thought I would round it all out while I was in the code). 
> > > Richard
> > 
> > <oracle_sig_logo.gif>
> > David Grieve | Principal Member of Technical Staff
> > Mobile: +16033121013 
> > Oracle Java Client UI and Tools
> > Durham, NH 03824 
> > <green-for-email-sig_0.gif> Oracle is committed to developing practices and \
> > products that help protect the environment 
> 


[prev in list] [next in list] [prev in thread] [next in thread]