[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-nio-dev
Subject:    Re: RFR: JDK-8326853 Missing @ since tags for Charset related methods added in Java 10 [v8]
From:       Nizar Benalla <duke () openjdk ! org>
Date:       2024-03-22 15:52:28
Message-ID: ybe6vfwdT6TWJEIUIvx7aJrcFaEKGNKuoQZZ05Q6k90=.b3b2a78f-80f4-4a4a-9321-42ca44a9eaf2 () github ! com
[Download RAW message or body]

On Thu, 21 Mar 2024 16:50:31 GMT, Justin Lu <jlu@openjdk.org> wrote:

> > Thank you justin
> 
> Hi @nizarbenalla , you can comment `/integrate` whenever you're ready, and we can \
> sponsor the change to have it integrated.

@justin-curtis-lu I realized there is a small issue with the commit message

8326853: Missing @since tags for Charset related methods added in Java 10

Reviewed-by: jlu, naoto

there is a github user with the username `@since` and he will be tagged in the commit \
message, so there should be a space here. I added a space in the PR title

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18032#issuecomment-2015380584


[prev in list] [next in list] [prev in thread] [next in thread]