[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-nio-dev
Subject:    Integrated: 8303972: (zipfs) Make test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java independent o
From:       Eirik =?UTF-8?B?QmrDuHJzbsO4cw==?= <eirbjo () openjdk ! org>
Date:       2024-02-18 15:28:58
Message-ID: 3q4OuZ6NXCNHHK3e9FpzeQwBMjUrCBG-u-BQ2p4N3WQ=.54f98be6-52ab-4901-a515-42570da4161a () github ! com
[Download RAW message or body]

On Fri, 10 Mar 2023 15:10:29 GMT, Eirik Bjørsnøs <eirbjo@openjdk.org> wrote:

> Please review this PR which brings the currenly problem-listed test \
> TestLocOffsetFromZip64EF back to life. 
> Instead of calling out to the `zip` command line, we produce a small-sized Zip64 \
> file in the test itself. This file has the features  required to reproduce the \
> ZipFileSystem issue, namely that the 'INFO-ZIP extended timestamp' field must come \
> before  the 'Zip64 extended information'  field. (This would casue ZipFileSystem to \
> read the LOC at position 0xFFFFFFFF). 
> This speed up the test (from 50s to 3s on my Macbook Pro), saves 4 GB disk space \
> during builds and removes a brittle dependency on the `zip` command in OS/distros. 
> Seee [JDK-8301183](https://bugs.openjdk.org/browse/JDK-8301183) for details on the \
> problem-listing.

This pull request has now been integrated.

Changeset: 7004c272
Author:    Eirik Bjørsnøs <eirbjo@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/7004c2724d9b150112c66febb7f24b781ff379dd
                
Stats:     209 lines in 2 files changed: 90 ins; 44 del; 75 mod

8303972: (zipfs) Make test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java \
                independent of the zip command line
8301183: (zipfs) jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java failing with \
ZipException:R0 on OL9

Reviewed-by: lancea

-------------

PR: https://git.openjdk.org/jdk/pull/12979


[prev in list] [next in list] [prev in thread] [next in thread]