[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-nio-dev
Subject:    Re: RFR: 8321802: (zipfs) Add validation of incorrect LOC signature in ZipFileSystem [v2]
From:       Alan Bateman <alanb () openjdk ! org>
Date:       2023-12-17 9:27:43
Message-ID: 8cxgLJ5LPAoaRCME7HWOPrR1Gj4uYPNQ3hzCl_YpRjw=.8499a2eb-e01d-45e2-be7a-01548c8a0037 () github ! com
[Download RAW message or body]

On Tue, 12 Dec 2023 11:59:36 GMT, Eirik Bjorsnos <duke@openjdk.org> wrote:

> > Please review this PR which adds validation of incorrect LOC signatures in \
> > `ZipFileSystem`. 
> > `ZipFile` already rejects the case where the  offset pointed to from the CEN \
> > header does not start with the expected LOC signature. It makes sense to add this \
> > check to `ZipFileSystem` as well.
> 
> Eirik Bjorsnos has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Use uppercase LOC in ZipException messages

Marked as reviewed by alanb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17059#pullrequestreview-1785407026


[prev in list] [next in list] [prev in thread] [next in thread]