[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-nio-dev
Subject:    Re: RFR: 8277361: java/nio/channels/Channels/ReadXBytes.java fails with OOM error
From:       Lance Andersen <lancea () openjdk ! java ! net>
Date:       2021-12-07 12:04:12
Message-ID: rYnw27LGe___UK2hJ2KJveVK9GwKyWafwAUCUwPAHUk=.d7288c39-e0b4-48c0-89d0-ac37e10b2548 () github ! com
[Download RAW message or body]

On Tue, 7 Dec 2021 01:47:47 GMT, Brian Burkhalter <bpb@openjdk.org> wrote:

> This request would increase the amount of heap memory that the test can use, and \
> decrease execution time by not writing the entirety of test files.

Looks good Brian

Minor suggestion below

test/jdk/java/nio/channels/Channels/ReadXBytes.java line 105:

> 103:         try (FileChannel fc = FileChannel.open(file, WRITE);) {
> 104:             long pos = 0L;
> 105:             if (length >= 2L*1024*1024*1024) {

Maybe consider a constant or a comment for extra clarity

-------------

Marked as reviewed by lancea (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6732


[prev in list] [next in list] [prev in thread] [next in thread]