[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-nio-dev
Subject:    Re: RFR: 8255380: (zipfs) ZipFileSystem::readExtra can fail if zipinfo-time is not set to false [v3]
From:       Claes Redestad <redestad () openjdk ! java ! net>
Date:       2020-11-02 10:50:56
Message-ID: vrj5fsQoKY_xxjLGi2ng15amemh_89EdP2J0TpUf57w=.cb969360-5ebf-47ef-9034-4679bdee3b88 () github ! com
[Download RAW message or body]

On Mon, 2 Nov 2020 00:28:08 GMT, Lance Andersen <lancea@openjdk.org> wrote:

> > Hi,
> > 
> > Please review the fix for JDK-8255380 which addresses an issue when the Zip file \
> > is > 4GB.  Zip FS when processing the CEN extra data does not take into account \
> > the fact that there is no specific order to how the extra data fields are \
> > written.  Info-ZIP writes the fields in a different order than Zip FS which \
> > presents a problem when evaluating the Info-ZIP extended timestamp and the LOC \
> > offset is 0XFFFFFFFF therefore the LOC offset needs to be read from the \
> > EXTID_ZIP64 extra data prior to attempting to read the LOC extra data field. 
> > The fix will defer reading of the LOC extra data field, if needed until all of \
> > the CEN extra data has been processed. 
> > Using jdk.nio.zipfs.ZipInfo, you can see the ordering difference of the CEND \
> > extra data fields when using Zip FS and info-zip. 
> > Info-zip is included with Mac OS so the test uses ProcessBuilder to execute zip \
> > on Mac OS and Linux.   
> > Mach5 tests jdk-tier1, jdk-tier2, and jdk-tier3 run cleanly.
> > 
> > Best,
> > Lance
> 
> Lance Andersen has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Convert test to being a manual test

Marked as reviewed by redestad (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/987


[prev in list] [next in list] [prev in thread] [next in thread]