[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-nio-dev
Subject:    Integrated: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk
From:       Philippe Marschall <github.com+471021+marschall () openjdk ! java ! net>
Date:       2020-09-30 20:07:31
Message-ID: GZ_dp8ZoqYV7mdU8wdrzRTRGgLytTsHOthZ5bJtEJh0=.c699e900-4f2a-40e3-8511-542f69f9fae8 () github ! com
[Download RAW message or body]

On Mon, 7 Sep 2020 09:44:09 GMT, Philippe Marschall \
<github.com+471021+marschall@openjdk.org> wrote:

> Hello, newbie here
> 
> I picked JDK-8138732 to work on because it has a "starter" label and I believe I \
> understand what to do. 
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from 9 to 16 since it is a new annotation name in a \
>                 new package.
> - I tried to keep code changes to a minimum, eg not change to imports if fully \
> qualified class names are used instead of imports. In some cases I did minor \
>                 reordering of imports to keep them sorted alphabetically.
> - All tier1 tests pass.
> - One jpackage/jlink tier2 test fails but I don't believe it is related.
> - Some tier3 Swing tests fail but I don't think they are related.

This pull request has now been integrated.

Changeset: 2a406f3c
Author:    Philippe Marschall <philippe.marschall@gmail.com>
Committer: Vladimir Kozlov <kvn@openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/2a406f3c
Stats:     749 lines in 65 files changed: 149 ins; 149 del; 451 mod

8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the \
jdk.internal.vm.annotation package

Reviewed-by: dholmes, alanb, psandoz, kvn, egahlin

-------------

PR: https://git.openjdk.java.net/jdk/pull/45


[prev in list] [next in list] [prev in thread] [next in thread]