[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-nio-dev
Subject: Re: 8229280: Test failures on several linux hosts after JDK-8181493
From: Brian Burkhalter <brian.burkhalter () oracle ! com>
Date: 2019-08-29 0:56:24
Message-ID: F8E8A71C-8766-42FD-90E5-86592839286D () oracle ! com
[Download RAW message or body]
> On Aug 28, 2019, at 2:16 AM, Alan Bateman <Alan.Bateman@oracle.com> wrote:
>
> On 26/08/2019 19:45, Brian Burkhalter wrote:
> > Ping ...
> Can this test be changed to call UnixNativeDispatcher.futimensSupported \
> reflectively? I think that would eliminate the most of the complexity and retry in \
> this test.
Done [1]. Note however that futimens() can be supported without it actually being \
able to set the timestamps to nanosecond precision, e.g., for HFS file systems on \
macOS. Therefore the test will still pass if the actual and expected values are not \
equal due to truncation of a multiple of three digits of precision.
Thanks,
Brian
[1] http://cr.openjdk.java.net/~bpb/8229280/webrev.01/
[Attachment #3 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html; \
charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; line-break: after-white-space;" class=""><br class=""><div><blockquote \
type="cite" class=""><div class="">On Aug 28, 2019, at 2:16 AM, Alan Bateman <<a \
href="mailto:Alan.Bateman@oracle.com" class="">Alan.Bateman@oracle.com</a>> \
wrote:</div><br class="Apple-interchange-newline"><div class=""><span \
style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; \
font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: \
normal; text-align: start; text-indent: 0px; text-transform: none; white-space: \
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; \
float: none; display: inline !important;" class="">On 26/08/2019 19:45, Brian \
Burkhalter wrote:</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; \
font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; \
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration: none;" class=""><blockquote type="cite" style="font-family: \
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; \
font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; \
text-indent: 0px; text-transform: none; white-space: normal; widows: auto; \
word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; \
text-decoration: none;" class="">Ping ...<br class=""></blockquote><span \
style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; \
font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: \
normal; text-align: start; text-indent: 0px; text-transform: none; white-space: \
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; \
float: none; display: inline !important;" class="">Can this test be changed to call \
UnixNativeDispatcher.futimensSupported reflectively? I think that would eliminate the \
most of the complexity and retry in this test.</span></div></blockquote></div><br \
class=""><div class="">Done [1]. Note however that futimens() can be supported \
without it actually being able to set the timestamps to nanosecond precision, e.g., \
for HFS file systems on macOS. Therefore the test will still pass if the actual and \
expected values are not equal due to truncation of a multiple of three digits of \
precision.</div><div class=""><br class=""></div><div class="">Thanks,</div><div \
class=""><br class=""></div><div class="">Brian</div><div class=""><br \
class=""></div><div class="">[1] <a \
href="http://cr.openjdk.java.net/~bpb/8229280/webrev.01/" \
class="">http://cr.openjdk.java.net/~bpb/8229280/webrev.01/</a></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic