[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-nio-dev
Subject: RE: RFR(S): 8223597: jdk/nio/zipfs/ZipFSTester.java RuntimeException: CHECK_FAILED! (getAttribute.cr
From: "Langer, Christoph" <christoph.langer () sap ! com>
Date: 2019-05-14 8:22:14
Message-ID: AM6PR02MB5192CA102FD6E12B5E7F498B8A080 () AM6PR02MB5192 ! eurprd02 ! prod ! outlook ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Thanks, Lance.
From: Lance Andersen <lance.andersen@oracle.com>
Sent: Montag, 13. Mai 2019 19:00
To: Langer, Christoph <christoph.langer@sap.com>
Cc: core-libs-dev <core-libs-dev@openjdk.java.net>; nio-dev <nio-dev@openjd=
k.java.net>
Subject: Re: RFR(S): 8223597: jdk/nio/zipfs/ZipFSTester.java RuntimeExcepti=
on: CHECK_FAILED! (getAttribute.crc <entries20> failed 6af4413c vs 0 ...)
Hi Christoph,
The change seems reasonable.
On May 13, 2019, at 8:14 AM, Langer, Christoph <christoph.langer@sap.com<ma=
ilto:christoph.langer@sap.com>> wrote:
Hi,
please review this fix of a regression in zipfs after JDK-8222532 [0].
Bug: https://bugs.openjdk.java.net/browse/JDK-8223597
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8223597.0/
The issue occurs when an empty file/channel is persisted into a zip file. T=
he entry had already been compressed with CRC of 0 at the time the output s=
tream to the zipfs was closed. But when the Entry is eventually synced to t=
he zip file, this is not detected and the bytes get compressed again.
The test was adapted to reliably provoke this intermittent error. In the te=
st I also suppressed printout of an expected Exception to avoid some distra=
ction when reading its JTR files.
Thanks
Christoph
[0] https://bugs.openjdk.java.net/browse/JDK-8222532
[cid:image001.gif@01D50A3E.E551EFA0]<http://oracle.com/us/design/oracle-ema=
il-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Pr=
incipal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen@oracle.com<mailto:Lance.Andersen@oracle.com>
[Attachment #5 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:Helvetica;
panose-1:2 11 6 4 2 2 2 2 2 4;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Verdana;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.apple-converted-space
{mso-style-name:apple-converted-space;}
span.apple-style-span
{mso-style-name:apple-style-span;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DE" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Thanks, \
Lance.<o:p></o:p></span></p> <p class="MsoNormal"><span \
style="mso-fareast-language:EN-US"><o:p> </o:p></span></p> <div \
style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> Lance \
Andersen <lance.andersen@oracle.com> <br>
<b>Sent:</b> Montag, 13. Mai 2019 19:00<br>
<b>To:</b> Langer, Christoph <christoph.langer@sap.com><br>
<b>Cc:</b> core-libs-dev <core-libs-dev@openjdk.java.net>; nio-dev \
<nio-dev@openjdk.java.net><br> <b>Subject:</b> Re: RFR(S): 8223597: \
jdk/nio/zipfs/ZipFSTester.java RuntimeException: CHECK_FAILED! (getAttribute.crc \
<entries20> failed 6af4413c vs 0 ...)<o:p></o:p></span></p> </div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi Christoph,<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">The change seems reasonable.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">On May 13, 2019, at 8:14 AM, Langer, Christoph <<a \
href="mailto:christoph.langer@sap.com">christoph.langer@sap.com</a>> \
wrote:<o:p></o:p></p> </div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">Hi,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">please review this fix of a regression in \
zipfs after JDK-8222532 [0].</span><o:p></o:p></p> </div>
<div>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">Bug:<span \
class="apple-converted-space"> </span><a \
href="https://bugs.openjdk.java.net/browse/JDK-8223597"><span \
style="color:#954F72">https://bugs.openjdk.java.net/browse/JDK-8223597</span></a></span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">Webrev:<span \
class="apple-converted-space"> </span><a \
href="http://cr.openjdk.java.net/~clanger/webrevs/8223597.0/"><span \
style="color:#954F72">http://cr.openjdk.java.net/~clanger/webrevs/8223597.0/</span></a></span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">The issue occurs when an empty file/channel \
is persisted into a zip file. The entry had already been compressed with CRC of 0 at \
the time the output stream to the zipfs was closed. But when the Entry is eventually \
synced to the zip file, this is not detected and the bytes get compressed \
again.</span><o:p></o:p></p> </div>
<div>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">The test was adapted to reliably provoke this \
intermittent error. In the test I also suppressed printout of an expected Exception \
to avoid some distraction when reading its JTR files.</span><o:p></o:p></p> </div>
</div>
</blockquote>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<div>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">Thanks</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">Christoph</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">[0]<span \
class="apple-converted-space"> </span><a \
href="https://bugs.openjdk.java.net/browse/JDK-8222532"><span \
style="color:#954F72">https://bugs.openjdk.java.net/browse/JDK-8222532</span></a></span><o:p></o:p></p>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal"><span class="apple-style-span"><span \
style="font-size:12.0pt;font-family:"Verdana",sans-serif;color:#666666"><a \
href="http://oracle.com/us/design/oracle-email-sig-198324.gif"><span \
style="text-decoration:none"><img border="0" width="114" height="26" \
style="width:1.1875in;height:.2708in" id="_x0034_79672C7-CA8E-4C3F-B79A-4346BA31CB41" \
src="cid:image001.gif@01D50A3E.E551EFA0"></span></a></span></span><span \
class="apple-style-span"><span \
style="font-size:12.0pt;font-family:"Verdana",sans-serif;color:#666666"><o:p></o:p></span></span></p>
<div>
<p class="MsoNormal"><span \
style="font-size:13.5pt;font-family:"Helvetica",sans-serif;color:black"><a \
href="http://oracle.com/us/design/oracle-email-sig-198324.gif"><br> </a></span><span \
style="font-size:12.0pt;font-family:"Verdana",sans-serif;color:#666666">Lance \
Andersen| Principal Member of Technical Staff | +1.781.442.2037<br> </span><span \
style="font-size:12.0pt;font-family:"Verdana",sans-serif;color:red">Oracle</span><span \
style="font-size:12.0pt;font-family:"Verdana",sans-serif;color:#666666"> Java \
Engineering <br> 1 Network Drive <br>
Burlington, MA 01803<br>
</span><span style="font-size:13.5pt;font-family:"Helvetica",sans-serif;color:black"><a \
href="mailto:Lance.Andersen@oracle.com"><span \
style="font-size:12.0pt;font-family:"Verdana",sans-serif">Lance.Andersen@oracle.com</span></a></span><span \
style="font-size:13.5pt;font-family:"Helvetica",sans-serif;color:black"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span \
style="font-size:12.0pt;font-family:"Helvetica",sans-serif;color:black"><o:p> </o:p></span></p>
</div>
<p class="MsoNormal"><span \
style="font-size:12.0pt;font-family:"Verdana",sans-serif;color:#666666"><br>
<br>
</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</div>
</body>
</html>
["image001.gif" (image/gif)]
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic