[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-nio-dev
Subject:    Re: JDK 10 RFR of 8184807: (ch) Clean up handling of some Windows function return values in libnio
From:       Brian Burkhalter <brian.burkhalter () oracle ! com>
Date:       2017-07-19 18:43:49
Message-ID: 504DF693-CFD0-496D-AFBC-DD6B24F00D9F () oracle ! com
[Download RAW message or body]

Hi Vyom,

It=92s too late for this patch, which had already been pushed before =
your message was sent, so perhaps in the future. However I am probably =
missing something, but I do not see any such unused variables in [1] or =
[2]. Would you please provide the specific line numbers in question?

Thanks,

Brian

[1] =
http://hg.openjdk.java.net/jdk10/jdk10/jdk/file/4fb5f3049c2c/src/java.base=
/windows/native/libnio/ch/FileChannelImpl.c
[2] =
http://hg.openjdk.java.net/jdk10/jdk10/jdk/file/4fb5f3049c2c/src/java.base=
/windows/native/libnio/ch/WindowsAsynchronousFileChannelImpl.c

On Jul 18, 2017, at 9:05 PM, vyom tewari <vyom.tewari@oracle.com> wrote:

> You can remove the unnecessary local variable "BOOL result" from =
WindowsAsynchronousFileChannelImpl.c & FileChannelImpl.c.


[Attachment #3 (unknown)]

<html><head><meta http-equiv="Content-Type" content="text/html \
charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; -webkit-line-break: after-white-space;">Hi Vyom,<div><br></div><div>It’s too \
late for this patch, which had already been pushed before your message was sent, so \
perhaps in the future. However I am probably missing something, but I do not see any \
such unused variables in [1] or [2]. Would you please provide the specific line \
numbers in question?</div><div><br></div><div>Thanks,</div><div><br></div><div>Brian</div><div><br></div><div>[1]&nbsp;<a \
href="http://hg.openjdk.java.net/jdk10/jdk10/jdk/file/4fb5f3049c2c/src/java.base/windo \
ws/native/libnio/ch/FileChannelImpl.c">http://hg.openjdk.java.net/jdk10/jdk10/jdk/file \
/4fb5f3049c2c/src/java.base/windows/native/libnio/ch/FileChannelImpl.c</a></div><div>[2]&nbsp;<a \
href="http://hg.openjdk.java.net/jdk10/jdk10/jdk/file/4fb5f3049c2c/src/java.base/windo \
ws/native/libnio/ch/WindowsAsynchronousFileChannelImpl.c">http://hg.openjdk.java.net/j \
dk10/jdk10/jdk/file/4fb5f3049c2c/src/java.base/windows/native/libnio/ch/WindowsAsynchronousFileChannelImpl.c</a></div><div><br><div><div>On \
Jul 18, 2017, at 9:05 PM, vyom tewari &lt;<a \
href="mailto:vyom.tewari@oracle.com">vyom.tewari@oracle.com</a>&gt; wrote:</div><br \
class="Apple-interchange-newline"><blockquote type="cite"><span style="font-family: \
Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: \
normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: \
start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; \
word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline \
!important;">You can remove the unnecessary local variable "BOOL result" from \
WindowsAsynchronousFileChannelImpl.c &amp; \
FileChannelImpl.c.</span></blockquote></div><br></div></body></html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic