[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-nio-dev
Subject:    Re: RFR 6856817: Poor performance of Writer#append with CharBuffer
From:       Daniel Fuchs <daniel.fuchs () oracle ! com>
Date:       2015-12-02 9:20:34
Message-ID: 565EB7E2.9060708 () oracle ! com
[Download RAW message or body]

Hi Vyom,

Looks good to me too.

If you don't get more comments from reviewers, send me the
exported changeset and I'll push it for you.

best regards,

-- daniel

On 11/25/15 3:29 PM, vyom wrote:
> Hi All,
>
> Please review my changes for below bug.
>
> Bug:        JDK-6856817 : Poor performance of Writer#append with 
> CharBuffer
> Webrev: http://cr.openjdk.java.net/~vtewari/6856817/webrev0.4/ 
> <http://cr.openjdk.java.net/%7Evtewari/6856817/webrev0.4/>
>
> This change will avoid the redundant toString/CharBuffer.wrap in case 
> of OutputStreamWriter.append(CharBuffer).
>
> In case of OutputStreamWriter.append(CharBuffer) we are doing 
> CharBuffer->String->char[]->CharBuffer conversion this change will 
> avoid redundant conversion.
>
> Thanks,
> Vyom
>

[prev in list] [next in list] [prev in thread] [next in thread]