[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-net-dev
Subject:    Re: RFR: 8332181: Deprecate for removal the java.net.MulticastSocket.setTTL/getTTL and the 2-arg sen
From:       Iris Clark <iris () openjdk ! org>
Date:       2024-05-17 17:26:04
Message-ID: j0tla6Kj0kAuIbEM6Eybp-bathSHfgQ2STaY1rOrV04=.b560afc4-5025-45ae-b1ca-ec027b9c0875 () github ! com
[Download RAW message or body]

On Fri, 17 May 2024 11:50:15 GMT, Jaikiran Pai <jpai@openjdk.org> wrote:

> > Can I please get a review of this change which proposes to deprecate for removal \
> > 3 methods on `java.net.MulticastSocket`? This addresses \
> > https://bugs.openjdk.org/browse/JDK-8332181. 
> > As noted in that issue these methods have been deprecated since Java 1.2 and 1.4 \
> > days. They currently have replacement methods (noted in their javadoc) which have \
> > been in use for several releases. This commit updates these deprecated methods to \
> > deprecated for removal, to allow for their removal in a future release. 
> > No new tests have been added and existing tests in tier1, tier2 and tier3 \
> > continue to pass.
> 
> Jaikiran Pai has updated the pull request incrementally with one additional commit \
> since the last revision: 
> also add forRemoval in internal classes

From the JCP POV, these changes look fine.  These changes match the associated CSR, \
which I've also Reviewed.

-------------

Marked as reviewed by iris (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19242#pullrequestreview-2064034102


[prev in list] [next in list] [prev in thread] [next in thread]