[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-net-dev
Subject:    Integrated: 8278353: Provide Duke as default favicon in Simple Web Server
From:       Christian Stein <cstein () openjdk ! org>
Date:       2024-05-08 5:51:02
Message-ID: eL7YEQ6NVvd2g-S0MpPdX62TRreoE2r0gy126_oDVHs=.b1165626-b842-4c5d-a248-47477955acf0 () github ! com
[Download RAW message or body]

On Tue, 30 Apr 2024 11:23:01 GMT, Christian Stein <cstein@openjdk.org> wrote:

> Please pre-review this draft pull request adding a default for response for the \
> `/favicon.ico` path to the Simple Web Server introduced by [JEP \
> 408](https://openjdk.org/jeps/408). The image in this PR is a copy of \
> https://inside.java/images/favicon.ico 
> Before this change, an initial request from a browser yields the following output \
> on the server console: 
> Binding to loopback by default. For all interfaces use "-b 0.0.0.0" or "-b ::".
> Serving PATH and subdirectories on 127.0.0.1 port 8000
> URL http://127.0.0.1:8000/
> 127.0.0.1 - - [30/Apr/2024:13:11:39 +0200] "GET / HTTP/1.1" 200 -
> 127.0.0.1 - - [30/Apr/2024:13:11:40 +0200] "GET /favicon.ico HTTP/1.1" 404 -
> 
> 
> After applying this change set, the two last line read:
> 
> 127.0.0.1 - - [30/Apr/2024:13:12:08 +0200] "GET / HTTP/1.1" 200 -
> 127.0.0.1 - - [30/Apr/2024:13:12:08 +0200] "GET /favicon.ico HTTP/1.1" 200 -
> 
> 
> Note that if the directory being served contains a `favicon.ico` file it is still \
> sent in favor of the default icon introduced by this change.

This pull request has now been integrated.

Changeset: 7b79426a
Author:    Christian Stein <cstein@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/7b79426a1da5896b0f00cf6e5fb4d2e754149e54
                
Stats:     104 lines in 4 files changed: 100 ins; 0 del; 4 mod

8278353: Provide Duke as default favicon in Simple Web Server

Reviewed-by: dfuchs

-------------

PR: https://git.openjdk.org/jdk/pull/19020


[prev in list] [next in list] [prev in thread] [next in thread]