[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-net-dev
Subject:    Re: RFR: 8308310: HttpClient: Avoid logging or locking from within synchronized blocks [v10]
From:       Jaikiran Pai <jpai () openjdk ! org>
Date:       2023-05-24 13:51:07
Message-ID: t28p-FimH09w085gaQEymj3trYwfMaOZztzZ8Mj2pH8=.d868c8f5-fcc1-461d-80ff-f073600a3f0a () github ! com
[Download RAW message or body]

On Wed, 24 May 2023 13:01:31 GMT, Daniel Fuchs <dfuchs@openjdk.org> wrote:

> > Please find here a change that revisits usage of monitors in the HttpClient.
> > 
> > With Virtual Threads now part of the platform it should be possible to pass a \
> > newVirtualThreadPerTaskExecutor to the HttpClient. Logging, when enabled, and \
> > when called from a synchronized block, can cause the carrier thread to get pinned \
> > in case of contention when printing through the underlying PrintStream. 
> > This change aims at avoiding situations where the carrier threads might get \
> > pinned.
> 
> Daniel Fuchs has updated the pull request incrementally with one additional commit \
> since the last revision: 
> More review feedback

Marked as reviewed by jpai (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/14038#pullrequestreview-1441918515


[prev in list] [next in list] [prev in thread] [next in thread]