[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-net-dev
Subject:    Re: RFR: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 ad
From:       Jaikiran Pai <jpai () openjdk ! org>
Date:       2023-05-19 7:24:53
Message-ID: 2jm2XhNWZZ7Bnjqra5pSa3jPAUtxo_IAxB3AGVrRh1s=.d8679325-6b49-467b-9e3e-e9e21bface45 () github ! com
[Download RAW message or body]

On Fri, 21 Apr 2023 01:26:35 GMT, Jaikiran Pai <jpai@openjdk.org> wrote:

> > Can I please get a review of this change which proposes to fix the issue reported \
> > in https://bugs.openjdk.org/browse/JDK-8305906? 
> > As noted in that issue, when IPv6 hosts are involved, the HttpClient on certain \
> > occasions can end up caching the connection with a key which doesn't match with \
> > the key which is then used in a subsequent request against the same target host.  \
> >  The commit in this PR now wraps the IPv6 address in a square bracket \
> > consistently so that the correct key is used both during storing the connection \
> > in the pool and when looking up. 
> > A new jtreg test has been added which reproduces this issue without the fix and \
> > verifies the fix.
> 
> Jaikiran Pai has updated the pull request incrementally with one additional commit \
> since the last revision: 
> wrapping into brackets is no longer needed

(can't believe it's already 4 weeks)
Please keep this open, I'll revive this shortly.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13456#issuecomment-1554150570


[prev in list] [next in list] [prev in thread] [next in thread]