[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-net-dev
Subject:    Re: RFR: 8264048: Fix caching in Jar URL connections when an entry is missing [v2]
From:       Brent Christian <bchristi () openjdk ! java ! net>
Date:       2021-03-31 17:34:18
Message-ID: zpy5blScTPGJeNKdM4LhuBOgyw8qzlwuq78xFMzs22M=.d66c47db-150f-402e-ac8a-30aedc5a9777 () github ! com
[Download RAW message or body]

On Wed, 31 Mar 2021 12:47:50 GMT, Aleksei Efimov <aefimov@openjdk.org> wrote:

> > Current fix tries to tackle an issue with URL connection referencing non-existing \
> > Jar file entries: If an entry that doesn't exist is specified in an URL \
> > connection the underlying Jar file is still cached even if an exception is thrown \
> > after that. Such behavior prevents the caller, for instance, a `URLClassLoader`, \
> > from closing a Jar file. 
> > The proposed fix checks if entry exists before caching a Jar file (only for cases \
> >                 with enabled caching):
> > - If entry exists - jar file is cached if it wasn't cached before
> > - If entry doesn't exist and jar file wasn't cached before - jar file is closed \
> >                 and exception is thrown
> > - If entry doesn't exist and jar file was cached before - jar file is kept cached \
> > and exception is thrown 
> > 
> > The following tests have been used to verify the fix:
> > - New regression tests
> > - ``:jdk_core:`` tests
> > - `api/java_util`,`api/java_net` JCK tests
> 
> Aleksei Efimov has updated the pull request incrementally with one additional \
> commit since the last revision: 
> JDK-8264048: Remove old version of RemoveJar test

Hi, Aleksei.  The change looks good.

-------------

Marked as reviewed by bchristi (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3263


[prev in list] [next in list] [prev in thread] [next in thread]