[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-net-dev
Subject: Re: RFR[8230132]: java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java to skip Teredo
From: Aleks Efimov <aleksej.efimov () oracle ! com>
Date: 2019-09-06 14:30:17
Message-ID: 1e9d39e0-a1f6-848c-1d0e-7a062943ac9e () oracle ! com
[Download RAW message or body]
Thanks Patrick,
Looks good to me.
With Best Regards,
Aleksei
On 04/09/2019 12:14, Patrick Concannon wrote:
>
> Hey Aleksei,
>
> Good idea. I've made that change, and it can be found in the webrev below.
>
> http://cr.openjdk.java.net/~dfuchs/pconcann/8230132/webrevs/webrev.2/
>
>
> Kind regards,
>
> Patrick
>
>
> On 02/09/2019 14:29, Aleks Efimov wrote:
>> Hey Patrick,
>>
>> Looks good to me!
>>
>> You could utilize jdk.test.lib.Platform::isWindows from test library
>> to check if the test is running on Windows platform.
>>
>> With Best Regards,
>> Aleksei
>>
>> On 29/08/2019 16:01, Patrick Concannon wrote:
>>>
>>> Hi,
>>>
>>> Would it be possible to have my fix for JDK-8230132 reviewed?
>>>
>>> java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java was
>>> failing intermittently on Windows due to random addresses being
>>> returned from the virtual interface "Teredo Tunneling
>>> Pseudo-Interface". The fix checks for, and skips, these interfaces -
>>> as was done for JDK-8038276.
>>> <https://bugs.openjdk.java.net/browse/JDK-8038276>
>>>
>>> Further information on this bug can be found here:
>>> https://bugs.openjdk.java.net/browse/JDK-8230132
>>>
>>> Webrev for fix:
>>> http://cr.openjdk.java.net/~dfuchs/pconcann/8230132/webrevs/webrev.1/
>>>
>>> Kind regards,
>>> Patrick
>>>
>>>
>>>
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Thanks Patrick,<br>
<br>
Looks good to me.<br>
<br>
With Best Regards,<br>
Aleksei<br>
<br>
<br>
<div class="moz-cite-prefix">On 04/09/2019 12:14, Patrick Concannon
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:74752839-fff0-6945-9dce-1c8424e5d995@oracle.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<p><tt>Hey Aleksei,</tt></p>
<p><tt>Good idea. I've made that change, and it can be found in
the webrev below.<br>
</tt></p>
<p><tt><a class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/~dfuchs/pconcann/8230132/webrevs/webrev.2/"
moz-do-not-send="true">http://cr.openjdk.java.net/~dfuchs/pconcann/8230132/webrevs/webrev.2/</a></tt></p>
<p><tt><br>
</tt></p>
<p><tt>Kind regards,</tt></p>
<p><tt>Patrick<br>
</tt></p>
<p><br>
</p>
<div class="moz-cite-prefix">On 02/09/2019 14:29, Aleks Efimov
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20036cdc-6e70-d693-eb7e-cdfa4589b795@oracle.com">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8">
Hey Patrick,<br>
<br>
Looks good to me!<br>
<br>
You could utilize jdk.test.lib.Platform::isWindows from test
library to check if the test is running on Windows platform.<br>
<br>
With Best Regards,<br>
Aleksei<br>
<br>
<div class="moz-cite-prefix">On 29/08/2019 16:01, Patrick
Concannon wrote:<br>
</div>
<blockquote type="cite"
cite="mid:8eef7c41-c905-a7d2-478e-0c69b1e56cc1@oracle.com">
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
<p>Hi, <br>
<br>
Would it be possible to have my fix for JDK-8230132
reviewed?</p>
<p><span style="color: rgb(29, 28, 29); font-family:
Slack-Lato, appleLogo, sans-serif; font-size: 15px;
font-style: normal; font-variant-ligatures:
common-ligatures; font-variant-caps: normal; font-weight:
400; letter-spacing: normal; orphans: 2; text-align: left;
text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(248,
248, 248); text-decoration-style: initial;
text-decoration-color: initial; display: inline
!important; float: none;"></span><span style="color:
rgb(29, 28, 29); font-family: Slack-Lato, appleLogo,
sans-serif; font-size: 15px; font-style: normal;
font-variant-ligatures: common-ligatures;
font-variant-caps: normal; font-weight: 400;
letter-spacing: normal; orphans: 2; text-align: left;
text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(248,
248, 248); text-decoration-style: initial;
text-decoration-color: initial; display: inline
!important; float: \
none;"></span>java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java was \
failing intermittently on Windows due to random addresses being returned from the \
virtual interface "Teredo Tunneling Pseudo-Interface". The fix checks for, and \
skips, these interfaces - as was done for <a
moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8038276">JDK-8038276.</a><br>
<br>
Further information on this bug can be found here: <a
moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8230132">https://bugs.openjdk.java.net/browse/JDK-8230132</a><br>
<br>
Webrev for fix: <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/~dfuchs/pconcann/8230132/webrevs/webrev.1/">http://cr.openjdk.java.net/~dfuchs/pconcann/8230132/webrevs/webrev.1/</a><br>
<br>
Kind regards,<br>
Patrick </p>
<p><br>
</p>
<p><br>
</p>
</blockquote>
</blockquote>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic