[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-net-dev
Subject:    Re: RFR: 8230310: SocksSocketImpl should handle the IllegalArgumentException thrown by ProxySelector
From:       Jaikiran Pai <jai.forums2013 () gmail ! com>
Date:       2019-08-29 10:41:44
Message-ID: f09c99c9-77f5-d7ea-3361-672a3a5fc16a () gmail ! com
[Download RAW message or body]


On 29/08/19 3:54 PM, Daniel Fuchs wrote:
> Thanks! Looks fine. I see you have used Assert.fail and that's
> better than what I suggested.
>
> I can be your sponsor if you want. Count me as Reviewer!

Yes please. I have updated the webrev at the same location, with just an
update to the Reviewed-by field in the commit log.

Thank you Daniel for reviewing and sponsoring.

-Jaikiran


>
> On 29/08/2019 10:48, Jaikiran Pai wrote:
>>> Maybe simply insert:
>>> =C2=A0=C2=A0=C2=A0 throw new AssertionError("expected exception not t=
hrown");
>>> between lines 75 and 76?
>> You are right of course, I missed that. I have now updated the test an=
d
>> the webrev is at the same location
>> http://cr.openjdk.java.net/~jpai/webrev/8230310/2/webrev/
>>
>> -Jaikiran
>>
>>
>
[prev in list] [next in list] [prev in thread] [next in thread]