[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-net-dev
Subject:    Re: RFR(XS): 8229912: [TESTBUG] java/net/Socks/SocksIPv6Test fails without IPv6
From:       Daniel Fuchs <daniel.fuchs () oracle ! com>
Date:       2019-08-21 12:56:12
Message-ID: 504a12a6-eacb-77bb-032b-f4785b8b6cf5 () oracle ! com
[Download RAW message or body]

On 21/08/2019 11:51, Alan Bateman wrote:
>> We could make those two methods return void and throw the 
>> SkipException themselves? I don't mind doing that change in this patch.
> I don't want to expand the scope of your changes, it was just a passing 
> comment. I think returning boolean is fine, I just think the method 
> names are misleading and they should not be printing anything. It's up 
> to the caller of these methods to decide whether to skip.

Agreed. If we encounter other tests built on the same
pattern that need to be skipped on IPv4 only environment
then we will consider moving/adding these to the test library
in IPSupport or NetworkConfiguration.

best regards,

-- daniel
[prev in list] [next in list] [prev in thread] [next in thread]