[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-net-dev
Subject:    Re: RFR 8224477 [13] java.net.Socket::setOption - implementation mismatch to spec
From:       Alan Bateman <Alan.Bateman () oracle ! com>
Date:       2019-05-27 18:42:51
Message-ID: 8ed9d7e1-6760-2f99-d765-b333954763ba () oracle ! com
[Download RAW message or body]



On 27/05/2019 19:37, Chris Hegarty wrote:
> > 
> Thanks, both issues resolved in-place.
Looks good.

> > 
> ServerSocket options are mentioned here as that is the behaviour in
> the current shipping release ( to return the server related options ), not
> the client related ones, see
> http://hg.openjdk.java.net/jdk/jdk/file/jdk-12-ga/src/java.base/share/classes/java/net/SocketImpl.java#l472
>  
> 
Ah okay, a custom SocketImpl has no support in the SPI to know if it's 
for a client or server socket. In that case, I think it looks fine (and 
more reason to return the empty Set as nothing else make sense).

-Alan


[prev in list] [next in list] [prev in thread] [next in thread]